I have a 1988 electraglide classic , the starter wont stop cranking untill i unhook the battery and after that there is a puddle of oil under the bike i was told it might be sumping

 

Sumping is normal only when the bike has been sitting a while.

As for your starter I'd start by replacing your starter relay.

 

Probably the solenoid on the sticking part. Take it apart and clean it up.

 

The solenoid and relay are both new this thing has me stumped i read that there is a whole bunch of things that can cause the starter to keep cranking

 

Check solenoid to see if disc hitting energizing wire under cap.

 

Have the starter relay loose but making connection, ready to pull out, the battery cable ready to pull off the battery, then push the button, let go, if it still has the starter engaged, pull the relay. If it stops, maybe a sticky relay. If it still has the starter engaged, pull the cable, probably a sticky solenoid.

And a "new" solenoid can be a complete POS too.

 

I tried to pull the relay the starter kept going, can i check the solenoid by unhooking the starter and push the start button

 

You could try, but it probably wouldn't make it stick. Under load, contacts tend to not want to come apart. Of course, if it did stick, that is, stayed closed once you released the button, as demonstrated by an ohm meter or test light, that would certainly indicate it was bad.

Exactly what brand "new" solenoid is this? I recommend only Genuine H.D. solenoids. Our solenoids are different than these newer ones.

 

If it's still hanging up after what you've done the contacts in the solenoid are welding themselves together. This is caused by the starter pulling too high an amperage. Most common causes in order are bad battery cables, dirty or loose connections, starter brushes are gone and it's arcing bad on the armature ( your's is old enough for this ) and even a failing battery. There's more but these are the usual problem or combination of problems.