So I changed my clutch cable on my 08 Nightster and when I put it all back together, I now get a noise when I put it in gear. Here's a link to a video so you can hear it. What did I mess up?

 

Check the tension of the primary chain. I always hear that sound on bikes with a primary chain that is too tight..................

 

Chain def to tight lots of video's and such on adjusting it.

 

I loosened the Primary until it was banging against the case. In ilde. Still got the noise. That's a different noise.

 

Are you sure you put the plates in the right order? Did you accidentally put two friction plates next to each other by accident? And did you start with the right plate in first? Should start with a friction plate first and then alternate with the steal plate. And the very middle plate should have been the Sp plate (spring plate) unless you put in a kit that eliminates that stupid spring plate.

 

OP indicated he changed the cable, but didn't say anything about the clutch pack.
I'd say take it apart (the cable interface, not the clutch pack), verify assembly, re-adjust the clutch screw and cable tension, then, see what happens. You gotta make sure the three ***** are seated in their ramps before adjusting the clutch.
It's interesting that the noise changes as you engage/dis-engage the clutch.

 

ok,
I took the cover off, remoed, the spring, the nut and other nut to take the clutch pack off. Everythign looked ok to me. I could "twist" the clutch and watch the ***** in thier ramps and see how it seperated the 2 halves of the clutch. Then put it all back together

When in Netural, all sounds fine ( clutch handle pulled in or not ).
When in first with the clutch handle pulled in, the noise is audible.
As the handle is released, the noise gets louder. There is minimal to no power getting to the wheels, and there is a burning smell.
Is it possible I unscrewed the adjsutment screw too much when talking the cluctch off to take the cable off?
I really can't see what it could be.

 

Maybe the replacement clutch cable was a different length than the original. Did you match them up to check before the install?

 

Oh yea, they are the same.

 

Where did you get your info on swapping a cable? Got a Service Manual? No need to remove the clutch.
Check this video, starting at 2:55. If there's more to it than that, tell us what transpired.