My '94 Fatboy would do this every few days, where 1 push of the Starter button = 1 click.

What fixed it was pulling the battery terminals off the battery and cleaning them. The positive (+) side in particular was visibly corroded.