The video is inconclusive but it looks like the top end has been replaced. The sound is a little like a loose pushrod but I could be way off. If the pushrod tubes have clips, you could check to see if you have adjustable pushrods. Motor might have lost a roller on a lifter.

With all the blackness of the plugs, it may be something as simple as carbon buildup in the chamber, that has flaked off and got caught between the piston and cylinder head.. You could try some seafoam to see if it helps.

Just guessing.

 

Thanks and I have great news. I tried it again today and the knock is completely gone. it does have some seafoam in it currently so maybe it was carbon. Still won’t idle so I guess I’ll be tearing into the carb now. I was terrified I’d be rebuilding the motor of my first Harley a week after buying it. Just to check do you think something like this could fix itself only to fully break later? Hate to start feeling good about it and have it blow up later. Thanks for the tips and safe riding

 

Ever seen the movie Christine? My bike always fixes itself after I park it each day.
But seriously...max said it sounded like a pushrod or possibly a lifter. Your symptom of knocking then no knocking could possibly point to a lifter that wasn't pumping up but now it is. If that is what's happening it's a good warning sign that you have one or more lifters that are going bad. You said the dealer changed the oil, have you checked the level? You wouldn't be the first person to have a dealer not fill it properly. Did it fix itself? Not likely and I'd rather find it in the comfort of my garage than out in the middle of nowhere. So I would definitely do some trouble shooting before I rode off on my next adventure

 

okay. I will say that I was on the starter a good bit trying to get her going then also when I was looking for some spark. You think that could do it to a lifter? I’m just not super used to dry sumps so idk.
Thanks